EscalationCondition.php: Set default operator value#511
Merged
BastianLedererIcinga merged 1 commit intoJul 15, 2026
Merged
Conversation
For the `incident_age` column, the `operator` select is disabled and only offers a single option (`>`). Disabled HTML selects don't submit a value, so the operator was previously missing from the submitted data and form could not be submitted. Defaulting the element's value to the first available option ensures it's always set, even while disabled.
sukhwinder33445
force-pushed
the
fix/escalation-rule-incindent-age-operator-submission
branch
from
July 15, 2026 07:04
3c12071 to
b096fb7
Compare
There was a problem hiding this comment.
Pull request overview
Fixes a form-submission edge case in the escalation condition configuration: when the incident_age column is selected, the operator <select> is disabled (and thus not submitted by the browser), causing the required operator value to be missing on submit.
Changes:
- Set a default value for the
operatorselect to the first available operator option (array_key_first($operators)), ensuring an operator is always present even when the field is disabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BastianLedererIcinga
approved these changes
Jul 15, 2026
BastianLedererIcinga
deleted the
fix/escalation-rule-incindent-age-operator-submission
branch
July 15, 2026 07:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the
incident_agecolumn, theoperatorselect is disabled and only offers a single option (>). Disabled HTML selects don't submit a value, so the operator was previously missing from the submitted data and form could not be submitted. Defaulting the element's value to the first available option ensures it's always set, even while disabled.